Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional exit-code table to counsel--async-cmd #421

Closed
wants to merge 1 commit into from

Conversation

@justbur
Copy link
Contributor

@justbur justbur commented Mar 7, 2016

This argument can be used to associate exit codes with the underlying
reason. Used in counsel-ag-function to signal that an exit code of 1
means that no matches were found.

For reference ggreer/the_silver_searcher#461

This argument can be used to associate exit codes with the underlying
reason. Used in counsel-ag-function to signal that an exit code of 1
means that no matches were found.
@justbur
Copy link
Contributor Author

@justbur justbur commented Mar 7, 2016

BTW, I noticed that the optional arguments for counsel--async-command don't seem to be used anywhere.

@abo-abo abo-abo closed this in 871f78c Mar 7, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 7, 2016

Thanks, please test - I rewrote it a bit.

For some reason, ag always returns "finished" event on my system.

But the customizations work fine for counsel-locate.

BTW, I noticed that the optional arguments for counsel--async-command don't seem to be used anywhere.

It was requested elsewhere in an issue.

@justbur
Copy link
Contributor Author

@justbur justbur commented Mar 8, 2016

Works fine for me. Thanks.

On Mon, Mar 7, 2016 at 4:11 PM Oleh Krehel notifications@github.com wrote:

Thanks, please test - I rewrote it a bit.

For some reason, ag always returns "finished" event on my system.

But the customizations work fine for counsel-locate.

BTW, I noticed that the optional arguments for counsel--async-command
don't seem to be used anywhere.

It was requested elsewhere in an issue.


Reply to this email directly or view it on GitHub
#421 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants