New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel--root-directory): Add #424

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@justbur
Contributor

justbur commented Mar 10, 2016

Add option (counsel-show-root-directory) to show root directory in
prompt of relevant commands, counsel-git, counsel-git-grep and
counsel-ag.

counsel.el (counsel--root-directory): Add
Add option (counsel-show-root-directory) to show root directory in
prompt of relevant commands, counsel-git, counsel-git-grep and
counsel-ag.

@abo-abo abo-abo closed this in 67224c0 Mar 10, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Mar 10, 2016

Thanks, I solved the problem in a slightly different, more customizable way.

@justbur

This comment has been minimized.

Contributor

justbur commented Mar 10, 2016

I like it. Thanks

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Mar 10, 2016

By the way, (split-string directory "/") doesn't look very portable. Did you test this on Windows?

@justbur

This comment has been minimized.

Contributor

justbur commented Mar 10, 2016

yes, but maybe you're right. On my computer paths get translated into forward slashes, but I'm not sure if this is version dependent.

@justbur

This comment has been minimized.

Contributor

justbur commented Mar 10, 2016

I'll try to rewrite it

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Mar 10, 2016

OK, thanks.

abo-abo added a commit that referenced this pull request Jun 20, 2016

ivy.el (ivy-set-prompt): New API
* ivy.el (ivy-prompt): Called to possibly update the prompt in
  `post-command-hook'.

* counsel.el (counsel-prompt-function): Mark as obsolete. Will be
  removed after a few months.
(counsel-prompt-function-default): Change from 1 arg to 0 args.
(counsel-prompt-function-dir): Change from 1 arg to 0 args.
(counsel-git):
(counsel-git-grep):
(counsel-ag): Use `ivy-set-prompt'.

* Makefile: New target "obsolete". Used to check if obsolete warnings
  work properly for the current obsolete variables.

* targets/obsolete-config.el: Used in conjunction with "make obsolete".

Re #424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment