Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-prompt-function-dir): Make portable #425

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@justbur
Copy link
Contributor

commented Mar 10, 2016

Use the built-in eshell-split-path to split the directory path into
components instead of split-string which is not likely to work on all
systems.

Note: I hope it's ok to depend on eshell here.

I also used three dots when the directory is truncated to avoid confusion with the standard meaning of two dots

@justbur

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2016

Also fixed that function which seemed to leave out the value of prompt unintentionally

justbur added some commits Mar 10, 2016

counsel.el (counsel-prompt-function-dir): Make portable
Use the built-in eshell-split-path to split the directory path into
components instead of split-string which is not likely to work on all
systems.
counsel.el (counsel-prompt-function-dir): Fix format
The prompt argument was unused, which looked unintentional

@justbur justbur force-pushed the justbur:add-root-dir-opt-2 branch to 73fe3d5 Mar 10, 2016

@justbur

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2016

Sorry, force pushed one more change. I'm done now.

@abo-abo abo-abo closed this in 5229ebe Mar 10, 2016

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.