counsel.el (counsel-prompt-function-dir): Make portable #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed that function which seemed to leave out the value of prompt unintentionally |
Use the built-in eshell-split-path to split the directory path into components instead of split-string which is not likely to work on all systems.
The prompt argument was unused, which looked unintentional
justbur
force-pushed
the
add-root-dir-opt-2
branch
from
d42d225 to
73fe3d5
Compare
|
Sorry, force pushed one more change. I'm done now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the built-in eshell-split-path to split the directory path into
components instead of split-string which is not likely to work on all
systems.
Note: I hope it's ok to depend on eshell here.
I also used three dots when the directory is truncated to avoid confusion with the standard meaning of two dots