Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel.el (counsel-prompt-function-dir): Make portable #425

Closed
wants to merge 2 commits into from

Conversation

@justbur
Copy link
Contributor

@justbur justbur commented Mar 10, 2016

Use the built-in eshell-split-path to split the directory path into
components instead of split-string which is not likely to work on all
systems.

Note: I hope it's ok to depend on eshell here.

I also used three dots when the directory is truncated to avoid confusion with the standard meaning of two dots

@justbur
Copy link
Contributor Author

@justbur justbur commented Mar 10, 2016

Also fixed that function which seemed to leave out the value of prompt unintentionally

Loading

justbur added 2 commits Mar 10, 2016
Use the built-in eshell-split-path to split the directory path into
components instead of split-string which is not likely to work on all
systems.
The prompt argument was unused, which looked unintentional
@justbur justbur force-pushed the add-root-dir-opt-2 branch from d42d225 to 73fe3d5 Mar 10, 2016
@justbur
Copy link
Contributor Author

@justbur justbur commented Mar 10, 2016

Sorry, force pushed one more change. I'm done now.

Loading

@abo-abo abo-abo closed this in 5229ebe Mar 10, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 10, 2016

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants