Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counsel-pt command and add transformer to counsel-ag #434

Merged
merged 2 commits into from Mar 14, 2016

Conversation

@justbur
Copy link
Contributor

@justbur justbur commented Mar 14, 2016

Also change command options to match git grep output. This is not
critical but it makes the commands more consistent.

Also change command options to match git grep output. This is not
critical but it makes the commands more consistent.
@justbur justbur force-pushed the ag-transformer branch from eea3a95 to 9fcd2f1 Mar 14, 2016
@justbur justbur changed the title counsel.el (counsel-ag): Add transformer Add counsel-pt command and add transformer to counsel-ag Mar 14, 2016
counsel.el (counsel-pt-base-command): Used in place of
counsel-ag-base-command for counsel-pt.
@justbur justbur force-pushed the ag-transformer branch from 9fcd2f1 to 0c5f68c Mar 14, 2016
@abo-abo abo-abo merged commit 0c5f68c into abo-abo:master Mar 14, 2016
1 check passed
Loading
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Mar 14, 2016

Thanks! Looks good, I only removed the args of counsel-pt since it did not use them.

Also, what's pt and how do you get and use it? How is it different than ag?

Loading

@justbur
Copy link
Contributor Author

@justbur justbur commented Mar 14, 2016

I only removed the args of counsel-pt since it did not use them.

whoops, thanks

Also, what's pt and how do you get and use it?

https://github.com/monochromegane/the_platinum_searcher

It's mostly just a rewrite of ag in Go. Since it's easier to build Go apps for windows, it's a little easier to get working on windows. That's the only difference really. I haven't noticed any big performance differences

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants