New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ivy to browse eshell and shell history entries #459

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@manuel-uberti
Contributor

manuel-uberti commented Apr 4, 2016

I am still waiting for the CA, but in the meantime I'm opening this PR as a reminder.

If you need me to fix anything in this commit, feel free to ask.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 6, 2016

Papers signed and sent, waiting for a reply.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 6, 2016

OK, thanks. It might take a while, make sure to email them if you get nothing for a month.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 8, 2016

Just got the email with the confirmation. Don't know how you can check whether I'm telling the truth or not, though. :)

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 8, 2016

I can check:). Is manuel@boccaperta.com the email that you used? I don't see it yet. It might take a day or two to propagate to gnuorg/copyright.list, ping the FSF guy otherwise.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 8, 2016

Yes, that's the email.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 8, 2016

Better ping the guy, just to make things faster. If I remember correctly, it took a week for @justbur email to appear on the list. But it took less in other cases.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 8, 2016

Well, he just wrote me with all the papers, I'll give it a day or two. Don't want to sound too impatient, he really was quick with my emails. :)

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 8, 2016

OK, it's good to see they're much faster now than a few years ago when I got my CA.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 11, 2016

I pinged the guy. No answer. Don't know if my name is there on the list yet.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 11, 2016

Not yet. The file shows up as updated today, but your email isn't there yet.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 13, 2016

Any news here? I still have no answer from the guy.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 13, 2016

Nope, still no change in the list.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 13, 2016

Yay! What a coincidence, I just got my answer: my name has been added to the list. :)

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 13, 2016

Ah, I finally see it. Welcome to the club!

@abo-abo abo-abo closed this in 41e2e41 Apr 13, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 13, 2016

Please look at the clean-up commit. The main thing is to do make compile to check that your change does not introduce warnings.

@manuel-uberti

This comment has been minimized.

Contributor

manuel-uberti commented Apr 13, 2016

Thank you.
I didn't know about make compile, could have saved you some work there. Sorry.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 13, 2016

No problem, thanks for the contribution. Also, there's make test. Travis CI checks it for you, but it doesn't hurt to run it on your own machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment