New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File sorting function using a priority order for extensions #498

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@ThibautVerron
Contributor

ThibautVerron commented May 3, 2016

This is just the sorting function, as suggested in issue #453.

I'm not sure of how this option is best presented to the user.
Also, in the long term, it would probably be a good idea to create a "purely ivy" variable replacing ido-file-extensions-order, in which case the new function could completely replace the default function.

File sorting function using a priority order for extensions
This is just the sorting function, as suggested in issue #453.

I'm not sure of how this option is best presented to the user.
Also, in the long term, it would probably be a good idea to create a "purely ivy" variable replacing `ido-file-extensions-order`, in which case the new function could completely replace the default function.

@abo-abo abo-abo merged commit 6c669ff into abo-abo:master May 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

abo-abo added a commit that referenced this pull request May 3, 2016

Fix previous commit
* ivy.el (ido): Don't require 'ido at top-level - it's not used by
  default.
(ido-file-extension-lessp): Add declaration.
(ivy-sort-file-function-using-ido): Clean up trailing whitespace.

Fixes #498
Fixes #453
@abo-abo

This comment has been minimized.

Owner

abo-abo commented May 3, 2016

Thanks for the contribution. Have a look at my subsequent fix. Also, look into getting an Emacs CA if you plan to contribute more in the future.

@ThibautVerron

This comment has been minimized.

Contributor

ThibautVerron commented May 4, 2016

Oh, yes, I forgot about declare-function. And I didn't know that ido is distributed with emacs, I'm learning so many things today, thanks!

It will be a long time before I feel safe enough to propose a 40 lines patch to a package, but when I do I'll definitely do the paperwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment