Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colir.el (colir-parse-color): Fix color parsing in terminal #543

Closed
wants to merge 1 commit into from
Closed

colir.el (colir-parse-color): Fix color parsing in terminal #543

wants to merge 1 commit into from

Conversation

@aslpavel
Copy link
Contributor

@aslpavel aslpavel commented Jun 8, 2016

Built-in color-name-to-rgb function is not working properly in terminal
as it maps parsed color to colosest available color from available
palette, and it is done before blending. This changes basically
adds function which basiacally parses color in # prefixed format,
and fallbacks to color-name-to-rgb otherwise.

Fixes #541

Built-in color-name-to-rgb function is not working properly in terminal
as it maps parsed color to colosest available color from available
palette, and it is done before blending. This changes basically
adds function which basiacally parses color in # prefixed format,
and fallbacks to color-name-to-rgb otherwise.

Fixes #541
@aslpavel
Copy link
Contributor Author

@aslpavel aslpavel commented Jun 8, 2016

Note highlighted line

GUI

gui

Terminal - Before

terminal - before

Terminal - After

terminal - after

@abo-abo abo-abo closed this in 65948fc Jun 8, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jun 8, 2016

Thanks for the code. I reworded it a bit to fit into the 15 line limit (without an Emacs Copyright Assignment, which I see that you don't have), and also because I don't like rx.

abo-abo added a commit that referenced this pull request Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants