Counsel set variable current val in prompt #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ivy--insert-prompt: The ivy--set-match-props calls inside this function have been moved to the new variable ivy--prompt-text-prop-override-function. That way, a user can override this variable using add-function, if needed. * ivy--set-match-props: To add granular control to text property overrides, now function accepts an optional fourth argument SUBEXP. By default, the PROPS text property is applied to the whole input string STR if it matches the regexp MATCH. Now it is possible to apply the text property only to a sub-expression. The default behavior is retained.
* counsel-set-variable: The current value of the selected variable is now also shown in the prompt, between the ‹..› brackets. That way, the current value of the variable is more explicit to the user.
|
Thanks. I prefer to avoid Unicode parens, so I replaced them with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now also shown in the prompt, between the ‹..› brackets. That way, the
current value of the variable is more explicit to the user.
Apologies! This PR includes my earlier PR ( #545) too. I forgot to rebase to upstream master before creating this commit.