New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counsel set variable current val in prompt #546

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kaushalmodi
Contributor

kaushalmodi commented Jun 9, 2016

  • counsel-set-variable: The current value of the selected variable is
    now also shown in the prompt, between the ‹..› brackets. That way, the
    current value of the variable is more explicit to the user.

Apologies! This PR includes my earlier PR ( #545) too. I forgot to rebase to upstream master before creating this commit.

kaushalmodi added some commits Jun 9, 2016

Make ivy prompt face overriding modular
* ivy--insert-prompt: The ivy--set-match-props calls inside this
function have been moved to the new variable
ivy--prompt-text-prop-override-function.  That way, a user can override
this variable using add-function, if needed.
* ivy--set-match-props: To add granular control to text property
  overrides, now function accepts an optional fourth argument SUBEXP.  By
  default, the PROPS text property is applied to the whole input string
  STR if it matches the regexp MATCH.  Now it is possible to apply the
  text property only to a sub-expression.  The default behavior is
  retained.
Show current value of the variable in the prompt
* counsel-set-variable: The current value of the selected variable is
  now also shown in the prompt, between the ‹..› brackets.  That way, the
  current value of the variable is more explicit to the user.
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jun 10, 2016

Thanks. I prefer to avoid Unicode parens, so I replaced them with <...>.

@kaushalmodi kaushalmodi deleted the kaushalmodi:counsel-set-variable-current-val-in-prompt branch Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment