Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't quit counsel-linux-app on bad data #604

Closed
wants to merge 1 commit into from

Conversation

@justbur
Copy link
Contributor

@justbur justbur commented Jul 28, 2016

  • counsel.el (counsel-linux-apps-list): Don't error on bad file. There
    is no need to throw an error because a single .desktop file is
    malformed. We can just skip it and issue a warning.
* counsel.el (counsel-linux-apps-list): Don't throw error for bad
  file. We can just skip the bad .desktop file and issue a warning.
@abo-abo abo-abo closed this in 64b385d Jul 28, 2016
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Jul 28, 2016

Thanks. I typically add errors for myself, in order to figure out the bad files. But warnings are probably better in this case.

@justbur
Copy link
Contributor Author

@justbur justbur commented Jul 28, 2016

Sure, I understand. It's just that I don't always want to have to stop and fix the bad file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants