Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 'counsel-bookmark' with the ability to create, edit, and delete bookmarks. #758

Merged
merged 1 commit into from Nov 5, 2016

Conversation

Projects
None yet
2 participants
@gilbertw1
Copy link
Contributor

commented Nov 4, 2016

This pull request removes the required match restriction from counsel-bookmark and allows a user to create a new bookmark if a match does not exist. Additionally it adds two additional actions that allow a bookmark to either be renamed or deleted.

This solves one minor pain point I ran into in my conversion from helm to ivy.

Also, I've submitted a request to 'assign@gnu.org'. I'll update this pull request once the copyright assignment has been completed.

@abo-abo abo-abo merged commit c8be397 into abo-abo:master Nov 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 5, 2016

Looks good, thanks.

Also, I've submitted a request to 'assign@gnu.org'.

For contributions cumulative to <15 lines, the assignment is not compulsory. But it will be handy if you want to contribute more.

@gilbertw1

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2016

Cool, thanks!

@gilbertw1 gilbertw1 deleted the gilbertw1:counsel-bookmark-create-edit-delete branch Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.