update 'counsel-bookmark' with the ability to create, edit, and delete bookmarks. #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks.
For contributions cumulative to <15 lines, the assignment is not compulsory. But it will be handy if you want to contribute more. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the required match restriction from
counsel-bookmarkand allows a user to create a new bookmark if a match does not exist. Additionally it adds two additional actions that allow a bookmark to either be renamed or deleted.This solves one minor pain point I ran into in my conversion from helm to ivy.
Also, I've submitted a request to 'assign@gnu.org'. I'll update this pull request once the copyright assignment has been completed.