New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink the window when/after reading actions. #764

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Yevgnen
Contributor

Yevgnen commented Nov 10, 2016

There are two commits in this pull request.

One is to deal with the action window height after dispatching action(Shrink ivy back to ivy-height).
The other one is to deal with the action height when reading action(Shrink action window to suitable height.

Please read the commit message for more details. Thanks !

Yevgnen added some commits Nov 10, 2016

Shrink ivy back to ivy-height after dispatching actions.
Before when there are too many actions, ivy will not go back to
original ivy-height after a C-g in ivy-dispatching-done or
performing ivy-dispatching-call. The function
ivy-shrink-after-dispatching deals with these situations.
Shrink ivy to suitable height when reading actions.
The original option 'grow-only is related to #402 .
Setting resize-mini-windows to t seems will not break
the original fix, but has the benefit that when
the action list is to small, it will shrink to suitable
height.

@abo-abo abo-abo closed this in 07388d0 Nov 10, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Nov 10, 2016

@Yevgnen Thanks.
@DWgit Please test.

@DWgit

This comment has been minimized.

DWgit commented Nov 12, 2016

Appears to work, thanks much.

On 11/10/2016 11:31 AM, Oleh Krehel wrote:

@Yevgnen https://github.com/Yevgnen Thanks.
@DWgit https://github.com/DWgit Please test.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#764 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AByTEdvJ_xhErj9lju3kVviAzq2ascbZks5q80bQgaJpZM4Kuo3X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment