New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make counsel-ag prompt for extra args when using prefix arg. #774

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Yevgnen
Contributor

Yevgnen commented Nov 14, 2016

Previously counsel-ag is only prompt for directory when
using a prefix arg. This commit make it prompt for extra
args too. The commit will also affect commands like
counsel-pt which invokes counsel-ag.

a

Thanks !

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Nov 14, 2016

Thanks. Do you already have the Emacs Copyright Assignment? You'll need it for more contributions, since ivy is in GNU ELPA.

@Yevgnen

This comment has been minimized.

Contributor

Yevgnen commented Nov 14, 2016

In progress. It seems that still need a small fix for function counsel-projectile-ag which also provide option prompt. I will fix it when have time. Please hold this on.

Yevgnen added some commits Nov 14, 2016

Make counsel-ag prompt for extra args when using prefix arg.
Previously counsel-ag is only prompt for directory when
using a prefix arg. This commit make it prompt for extra
args too. The commit will also affect commands like
counsel-pt which invokes counsel-ag.
@Yevgnen

This comment has been minimized.

Contributor

Yevgnen commented Dec 5, 2016

The assignment progress seems completed. My name is screen shot 2016-12-05 at 10 12 06 pm.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 5, 2016

Thanks. Your name is not yet propagated to the copyright.list file on fencepost. Could you please remind the copyright clerk to update that file?

@Yevgnen

This comment has been minimized.

Contributor

Yevgnen commented Dec 8, 2016

The clerk now confirms that

Hello,
Copyright.list has been updated to reflect the changes

Please check when you have time. 😁

@abo-abo abo-abo closed this in 4dd650c Dec 8, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 8, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment