Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counsel-rg for ripgrep #784

Merged
merged 1 commit into from
Nov 19, 2016
Merged

Add counsel-rg for ripgrep #784

merged 1 commit into from
Nov 19, 2016

Conversation

manuel-uberti
Copy link
Contributor

@manuel-uberti manuel-uberti commented Nov 19, 2016

This lets you use ripgrep via Counsel. It basically reuses counsel-ag like counsel-pt does.

I ran make compile, make test and M-x checkdoc before submitting this PR.

@manuel-uberti manuel-uberti changed the title Add counsel-rg Add counsel-rg for ripgrep Nov 19, 2016
This lets you use [ripgrep](https://github.com/BurntSushi/ripgrep) via Counsel.
@abo-abo abo-abo merged commit 5190412 into abo-abo:master Nov 19, 2016
@abo-abo
Copy link
Owner

abo-abo commented Nov 19, 2016

Thanks.

@manuel-uberti
Copy link
Contributor Author

Thank you for merging so quickly!

@abo-abo
Copy link
Owner

abo-abo commented Nov 19, 2016

Well, with magit's fa, mm 784, PP it's indeed quick to merge.

@manuel-uberti
Copy link
Contributor Author

manuel-uberti commented Nov 19, 2016

Actually, sorry, there is a bug: when I hit RET on the matching candidate, I don't get moved to its position in the buffer. Point doesn't move at all.

@manuel-uberti
Copy link
Contributor Author

manuel-uberti commented Nov 19, 2016

Yes, I know, but I fixed with this PR: #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants