Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #795: Address multiple problems with counsel-rg #796

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@mwolson
Copy link
Contributor

commented Nov 25, 2016

  • counsel-ag-function: Take base-cmd as a parameter instead of using counsel-ag-base-command
  • counsel-rg-base-command: Include line numbers and current directory so it works on Windows
  • Make counsel-rg a modified copy of counsel-ag instead of calling it, so we get a working occur buffer
  • Update docs to mention counsel-rg
  • ivy: Add 'counsel-rg to multiple memq lists that check for 'counsel-ag
Michael Olson
Fix #795: Address multiple problems with counsel-rg
* counsel-ag-function: Take base-cmd as a parameter instead of using counsel-ag-base-command
* counsel-rg-base-command: Include line numbers and current directory so it works on Windows
* Make counsel-rg a modified copy of counsel-ag instead of calling it, so we get a working occur buffer
* Update docs to mention counsel-rg
* ivy: Add 'counsel-rg to multiple memq lists that check for 'counsel-ag
@manuel-uberti

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2016

Thanks for working on this.

@abo-abo abo-abo closed this in 359a6c8 Nov 25, 2016

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 25, 2016

Thanks a lot for such a comprehensive improvement. I've reviewed the changes to ivy.el and ivy.org, haven't yet had the chance to test counsel-rg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.