New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three new counsel commands. #815

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@joedicastro
Contributor

joedicastro commented Dec 4, 2016

Added these three new counsel commands counsel-colors-web, counsel-colors-emacs and counsel-faces.

counsel-colors-emacs

counsel-colors-emacs

Show a list of all supported colors for a particular frame. This is very useful when developing a new theme, package or dealing with your configuration. This replaces the helm-colors, anything-colors and the default Emacs list-color-display. The colors available are different when you are on a terminal session or in a GUI one, this can be very helpful when developing a theme/package to test the compatibility.

counsel- colors-web

counsel-colors-web

Show a list of all W3C web colors for use in CSS. This is very useful for web developers.
These are the colors defined by the W3C consortium to use in CSS sheets. All of these colors are compatible with any common browser. The colors gray, green, maroon and purple have alternative values as defined by the X11 standard, here they follow the W3C one.

counsel-faces

counsel-faces

Show a list of all defined faces. Also very useful when developing a theme/package. This replaces the commands helm-colors, anything-colors and the Emacs default list-faces-display.

All of the command have several actions suited to the given context.

P.S. I already send by email the signed PDF for the FSF Copyright Assignment. They offer you this option now by default. I'm waiting an answer.

* counsel.el: added three new counsel commands.
Added `counsel-colors-web`, `counsel-colors-emacs` and `counsel-faces`.
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 5, 2016

Looks very impressive. Thanks a lot.

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 5, 2016

You're welcome, I hope that this would the first from a lot more. I'll tell you when I hear something from FSF.

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 6, 2016

I received right now the FSF notification that the assignment process is complete. Seems that now the process is really fast, if we not count the weekend in the middle, there were only three days.

@abo-abo abo-abo closed this in 039c58a Dec 7, 2016

abo-abo added a commit that referenced this pull request Dec 7, 2016

Use ivy-format-function approach for counsel-faces
* counsel.el (counsel-faces-action-describe): Remove defun.
(counsel-faces-action-describe): Simplify.
(counsel-faces-action-customize): Simplify.
(counsel-faces-action-insert-name): Replace with 'insert.
(counsel-faces-action-kill-name): Replace with 'kill-new.
(counsel--faces-fmt): New defvar.
(counsel--faces-format-function): New defun.
(counsel-faces): Update.

With this change, the candidates are simply (face-list).
Additionally, `counsel-faces--sample-text' is no longer matched, since
it's never part of the candidate text.

Re #815
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 7, 2016

Merged, thanks again.

I rewrote counsel-faces slightly, please check.

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 7, 2016

Oh, thanks to you, now is way better!

I didn't know how to do that, I still have to learn a lot about how Emacs works and Emacs Lisp. 👍

@joedicastro joedicastro deleted the joedicastro:colors_and_fonts branch Dec 7, 2016

@glucas

This comment has been minimized.

Contributor

glucas commented Dec 9, 2016

These are cool commands, thanks for adding.

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 9, 2016

@glucas You're welcome! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment