Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make counsel-ag support limiting in files. #820

Merged
merged 1 commit into from Dec 10, 2016
Merged

Make counsel-ag support limiting in files. #820

merged 1 commit into from Dec 10, 2016

Conversation

@Yevgnen
Copy link
Contributor

@Yevgnen Yevgnen commented Dec 9, 2016

This is be done by detecting " -- " in extra-ag-args after
prompting, since ag supports " -- pattern file1 file2" style
of searching.

Common usage is: C-u M-x counsel-ag, select a directory, adjust the optional arguments to something like --nocolor --nogroup -- package *.el, and search PATTERN, given results like
screen shot 2016-12-09 at 9 34 37 am

compared to the unlimited file version with argument --nocolor --nogroup

screen shot 2016-12-09 at 9 34 21 am

This is be done by detecting " -- " in extra-ag-args after
prompting, since ag supports " -- pattern file1 file2" style
of searching.
@abo-abo abo-abo merged commit 0312d5e into abo-abo:master Dec 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 10, 2016

Thanks.

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 10, 2016

With your change, the base-cmd arg is no longer used. Please review.

@Yevgnen
Copy link
Contributor Author

@Yevgnen Yevgnen commented Dec 10, 2016

Looks like it should be base-cmd on line 1693.

@Yevgnen
Copy link
Contributor Author

@Yevgnen Yevgnen commented Dec 10, 2016

Should I push a rebased commit(--force) or independent fixup in to branch ag-limit-in-file or create a new pull request ? I have no experience of this ...

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Dec 10, 2016

A new PR, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants