New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command `counsel-mark-ring' #834

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@akermu
Contributor

akermu commented Dec 18, 2016

No description provided.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 18, 2016

Thanks. Can you get the Emacs Copyright Assignment? See the README for more info.

Also, (delete-dups mark-ring) improves the command.

@joedicastro

This comment has been minimized.

Contributor

joedicastro commented Dec 18, 2016

Well, congratulations, this one command was in my TODO list, you got there first! Well done!

@akermu

This comment has been minimized.

Contributor

akermu commented Dec 18, 2016

I updated the PR with the suggestion of abo-abo and requested the CA from the FSF.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 18, 2016

@akermu Thanks.

@akermu

This comment has been minimized.

Contributor

akermu commented Jan 4, 2017

I got the CA from the FSF, do I have to post it here, @abo-abo?

@abo-abo abo-abo closed this in 58372db Jan 4, 2017

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Jan 4, 2017

@akermu Thanks, I see the CA. The commit is merged. One suggestion for improvement: sort the marks by their location, so that going up/down in candidate list also goes up/down in the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment