New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ivy--flx-sort more intelligent #843

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Projects
None yet
3 participants
@PythonNut
Contributor

PythonNut commented Dec 29, 2016

This improves the behavior of ivy--flx-sort. In particular, the following has been changed:

  • flx-score is not called on candidates that do not match the given input. (And the fuzzy matching is done in an optimized fashion.)
  • Even when the number of candidates exceeds ivy-flx-limit the first ivy-flx-limit candidates by length are still scored and sorted, which can often lead to quality results, even with large numbers of candidates and small inputs.
  • flx-score ties are broken by length (shorter wins)
@raxod502

This comment has been minimized.

Contributor

raxod502 commented Dec 29, 2016

This makes flx sorting much more enjoyable for me.

@abo-abo abo-abo merged commit dc693c3 into abo-abo:master Dec 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Dec 29, 2016

Thanks!

raxod502 added a commit to raxod502/radian that referenced this pull request Dec 29, 2016

Amend comment about ivy-flx-limit
The code referenced as a potential future solution has now been merged
into ivy upstream [1].

[1]: abo-abo/swiper#843

@raxod502 raxod502 referenced this pull request Jan 5, 2017

Closed

Better flx sorting in Ivy #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment