New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heed non-sort entries in ivy-sort-functions-alist #870

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@basil-conto
Contributor

basil-conto commented Feb 2, 2017

Currently, ivy--sort-function does not distinguish between collection functions that are not members of ivy-sort-functions-alist and ones whose associated sorting function is nil, i.e. no sorting.

In ivy-completing-read, this meant that the lookup in ivy-sort-functions-alist would always fall through to the default sorting function, even for existing collection functions whose CDR was explicitly set to nil.

Heed non-sort entries in ivy-sort-functions-alist
Currently, ivy--sort-function does not distinguish between
collection functions that are not members of
ivy-sort-functions-alist and ones whose associated sorting function
is nil, i.e. no sorting.

In ivy-completing-read, this meant that the lookup in
ivy-sort-functions-alist would always fall through to the default
sorting function, even for existing collection functions whose CDR
was explicitly set to nil.

@abo-abo abo-abo closed this in 65979f6 Feb 2, 2017

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Feb 2, 2017

Thanks.

@basil-conto basil-conto deleted the basil-conto:sort branch Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment