Heed non-sort entries in ivy-sort-functions-alist #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ivy--sort-function does not distinguish between collection functions that are not members of ivy-sort-functions-alist and ones whose associated sorting function is nil, i.e. no sorting. In ivy-completing-read, this meant that the lookup in ivy-sort-functions-alist would always fall through to the default sorting function, even for existing collection functions whose CDR was explicitly set to nil.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ivy--sort-functiondoes not distinguish between collection functions that are not members ofivy-sort-functions-alistand ones whose associated sorting function isnil, i.e. no sorting.In
ivy-completing-read, this meant that the lookup inivy-sort-functions-alistwould always fall through to the default sorting function, even for existing collection functions whoseCDRwas explicitly set tonil.