Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run wgrep-setup when entering ivy-occur-grep-mode #904

Merged
merged 1 commit into from Feb 25, 2017
Merged

Run wgrep-setup when entering ivy-occur-grep-mode #904

merged 1 commit into from Feb 25, 2017

Conversation

@joonoro
Copy link
Contributor

@joonoro joonoro commented Feb 25, 2017

wgrep-setup saves the local keymap when entering wgrep mode and
restores it when exiting. By adding a hook to run it when entering
ivy-occur-grep-mode we prevent the keymap from being lost after one
edit.

Fixes #711

wgrep-setup saves the local keymap when entering wgrep mode and
restores it when exiting. By adding a hook to run it when entering
ivy-occur-grep-mode we prevent the keymap from being lost after one
edit.
@abo-abo abo-abo merged commit c5fa8c2 into abo-abo:master Feb 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 25, 2017

Thanks for the fix.

@joonoro
Copy link
Contributor Author

@joonoro joonoro commented Feb 25, 2017

Actually it should check for the presence of wgrep instead of just blindly adding the hook, after all people might use ivy-occur without wgrep

abo-abo added a commit that referenced this pull request Feb 25, 2017
* ivy.el (ivy-occur-revert-buffer): Call `wgrep-setup', through
  `ivy-occur-grep-mode'.

Re #904
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Feb 25, 2017

Good point, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants