New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper.el (swiper--action): Set evil search direction to forward #947

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@edkolev
Contributor

edkolev commented Apr 6, 2017

Without setting evil-ex-search-direction, evil-search-next and
evil-search-previous (bound to n and N in evil-mode) will repeat
swiper's last search, but will use the direction of the pre-swiper
search. If there is no previous search before swiper, evil-search-next
and evil-search-previous will not work. swiper doesn't have a concept
of backward search, hence it makes sense to always set direction to
'forward.

swiper.el (swiper--action): Set evil search direction to forward
Without setting evil-ex-search-direction, evil-search-next and
evil-search-previous (bound to `n` and `N` in evil-mode) will repeat
swiper's last search, but will use the direction of the pre-swiper
search. If there is no previous search before swiper, evil-search-next
and evil-search-previous will not work. swiper doesn't have a concept
of `backward` search, hence it makes sense to always set direction to
'forward.
@edkolev

This comment has been minimized.

Contributor

edkolev commented Apr 6, 2017

The commit message is a bit wordy, please let me know if the PR can be improved.

This PR will fix emacs-evil/evil#712

@abo-abo abo-abo merged commit fc2e198 into abo-abo:master Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo

This comment has been minimized.

Owner

abo-abo commented Apr 6, 2017

Thanks.

The commit message is a bit wordy

That's how I like them:)

@edkolev

This comment has been minimized.

Contributor

edkolev commented Apr 6, 2017

Nice, thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment