Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy-read-action): Allow quit by ESC for better work with evil #952

Closed
wants to merge 1 commit into from

Conversation

@deftsp
Copy link
Contributor

@deftsp deftsp commented Apr 10, 2017

No description provided.

@abo-abo abo-abo closed this in d9608bf Apr 10, 2017
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Apr 10, 2017

Thanks.

@@ -587,7 +587,7 @@ selection, non-nil otherwise."
(action-idx (cl-position-if
(lambda (x) (equal (car x) key))
(cdr actions))))
(cond ((string= key "")
(cond ((or (string= key "") (string= key ""))

This comment has been minimized.

@Somelauw

Somelauw Apr 11, 2017

Why are you comparing key to an empty string twice?

This comment has been minimized.

@deftsp

deftsp Apr 12, 2017
Author Contributor

Read the source code with Emacs instead of Browser.

This comment has been minimized.

@Somelauw

Somelauw Apr 13, 2017

I see. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants