New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.el (ivy-read-action): Allow quit by ESC for better work with evil #952

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@deftsp
Contributor

deftsp commented Apr 10, 2017

No description provided.

@abo-abo abo-abo closed this in d9608bf Apr 10, 2017

@abo-abo

This comment has been minimized.

Show comment
Hide comment
@abo-abo

abo-abo Apr 10, 2017

Owner

Thanks.

Owner

abo-abo commented Apr 10, 2017

Thanks.

@@ -587,7 +587,7 @@ selection, non-nil otherwise."
(action-idx (cl-position-if
(lambda (x) (equal (car x) key))
(cdr actions))))
(cond ((string= key "")
(cond ((or (string= key "") (string= key ""))

This comment has been minimized.

@Somelauw

Somelauw Apr 11, 2017

Why are you comparing key to an empty string twice?

@Somelauw

Somelauw Apr 11, 2017

Why are you comparing key to an empty string twice?

This comment has been minimized.

@deftsp

deftsp Apr 12, 2017

Contributor

Read the source code with Emacs instead of Browser.

@deftsp

deftsp Apr 12, 2017

Contributor

Read the source code with Emacs instead of Browser.

This comment has been minimized.

@Somelauw

Somelauw Apr 13, 2017

I see. Thank you

@Somelauw

Somelauw Apr 13, 2017

I see. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment