Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlighting to counsel-describe-function #981

Merged
merged 2 commits into from May 1, 2017

Conversation

@justbur
Copy link
Contributor

@justbur justbur commented May 1, 2017

This is a similar idea to my last one. I also updated the docstrings for the two affected functions

justbur added 2 commits May 1, 2017
counsel.el (counsel-describe-function-transformer): Add
counsel.el (counsel-describe-function): Update docstring
@abo-abo abo-abo merged commit 3282871 into abo-abo:master May 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 1, 2017

Thanks. Looks a bit gaudy for my taste, since my font-lock-function-name-face is bold. I'll just turn it off in my config for now:

(ivy-set-display-transformer 'counsel-describe-function nil)

Still, it's probably a reasonable default for other users.

@justbur
Copy link
Contributor Author

@justbur justbur commented May 1, 2017

My theme has function-name and variable-name being the same and not too gaudy :).

Maybe a color from one of the ivy faces would be more appropriate for these?

@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 1, 2017

Maybe a color from one of the ivy faces would be more appropriate for these?

If you have something good in mind, I'm open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants