Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to save readonly files before calling counsel-grep #999

Conversation

@kaushalmodi
Copy link
Contributor

@kaushalmodi kaushalmodi commented May 11, 2017

  • counsel.el (counsel-grep-or-swiper): Save buffer only if the file is
    writable. Create let-bound fname instead of calling (buffer-file-name)
    multiple times.
* counsel.el (counsel-grep-or-swiper): Save buffer only if the file is
  writable.  Create let-bound fname instead of calling (buffer-file-name)
  multiple times.
@abo-abo abo-abo merged commit 101101d into abo-abo:master May 11, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented May 11, 2017

Thanks.

@kaushalmodi kaushalmodi deleted the kaushalmodi-forks:counsel-grep-or-swiper-on-readonly-files branch May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants