Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
$no_proxy support? #277
Normally proxy settings are automatically picked up via $http(s)_proxy env vars and also importantly $no_proxy which determines when NOT to use the proxy. Ruby's core http libs already support all of this automatically.
I see some scattered notes regarding env vars in the rest-client lib:
This is actually affecting me while trying to use the k8s plugin in gitlab:
It seems proper $no_proxy support and/or env var support would be right way to go?
Thanks. Can you help us map out the current situation? A PR with just tests for current kubeclient behavior would be wonderful (but manual "this worked and this didn't" is welcome too).
Note that kubeclient uses 2 libs — http for watches and rest-client for all other requests. rest-client is based on ruby's core Net::HTTP, http gem isn't.
Also, is current kubeclient API adequate if you're willing to parse env vars yourself?
Are these env vars standardized anywhere? I found https://wiki.archlinux.org/index.php/proxy_settings, sounds more like convention than standard.
P.S. found that Net::HTTP.new recently gained no_proxy param (but already supported no_proxy env var): https://bugs.ruby-lang.org/issues/11195