Andrei Botalov abotalov

@abotalov
Spaces after the tag name aren't allowed in end tag
abotalov commented on issue YorickPeterse/oga#104
@abotalov

It looks to me that the spec lexes nested <ul> elements containing unclosed <li> elements is incorrect. Currently <ul><li><ul><li>foo</ul><li>bar</ul

@abotalov
Script-supporting elements aren't permitted inside self-closing elements
abotalov commented on issue YorickPeterse/oga#101
@abotalov

One more example: <object> <ul> <li>Li </ul> Inside object </object> Outside object is currently equivalent to: <object> <ul> <li>Li </li> Inside…

abotalov commented on issue watir/watir-webdriver#340
@abotalov

Actually, current Watir's master doesn't work on Ruby 1.9.3 because of e.g. this - https://github.com/watir/watir-webdriver/blob/master/lib/watir-w…

abotalov commented on issue YorickPeterse/oga#101
@abotalov

I think the list of optional tags listed here is full. No other elements may have end tags that can be omitted.

abotalov commented on issue YorickPeterse/oga#101
@abotalov

When we bump into a new open tag while we're still in an unclosed tag, check if said new tag is allowed inside the unclosed tag. If this is not th…

abotalov commented on pull request rspec/rspec-expectations#776
@abotalov

On a side note, I'm thinking about recommending to the cucumber team that in their rspec-expectations integration they may want to wrap every step…

abotalov commented on issue YorickPeterse/oga#101
@abotalov

In the example above we know that a <form> element can not reside in a <td>, <tr>, <thead> and <table> element That's not true. The form element …

abotalov commented on issue YorickPeterse/oga#99
@abotalov

Some inconcistences with the current implementation (http://www.w3.org/TR/html51/semantics.html#the-table-element): 1. caption element should be al…

abotalov commented on issue YorickPeterse/oga#98
@abotalov

Do you think it makes sense to insert start tags if end tags are present? Oga.parse_html('</html>')

abotalov commented on issue YorickPeterse/oga#99
@abotalov

colgroup / tr / th elements are still closed in incorrect places. E.g. parsing example above currently results in: > puts Oga.parse_html(File.read('f…

abotalov deleted branch patch-1 at abotalov/webdriver
abotalov commented on pull request TheBlasfem/ruby-patterns#5
@abotalov

responsibilities

abotalov commented on pull request bbatsov/ruby-style-guide#353
@abotalov

fixed

@abotalov
  • @abotalov 5cf577b
    Hash#fetch with default value also has sometimes right to life
@abotalov
  • @sethkrasnianski cf0d2be
    Changed incorrect instances of 'arguments' to 'parameters'
  • @bbatsov ec660ca
    Add a rule suggesting the use of alternatives of String#gsub when pos…
  • 69 more commits »
@abotalov
abotalov commented on pull request bbatsov/ruby-style-guide#435
@abotalov

I believe 2 is better than 1. Mixing standard args with default values and keyword args is bad as it would lead to the necessity to always pass val…

abotalov commented on pull request bbatsov/ruby-style-guide#439
@abotalov

[link] shouldn't be shown on the separate line, I believe.

abotalov commented on pull request bbatsov/ruby-style-guide#439
@abotalov

} will also be shown greyed out on Github.

abotalov commented on pull request bbatsov/ruby-style-guide#435
@abotalov

IMO it's fine if a method receives standard arguments without default values and keyword arguments. It's just not fine to use standard arguments wi…

@abotalov
Add support for Ruby 1.9.3 back
abotalov commented on pull request leonid-shevtsov/headless#55
@abotalov

Do you think provider_binary is a good name? Do you think binary_file_path or provider_binary_file_path be better?

@abotalov
Omissions of thead / colgroup / tbody / tr / td elements aren't handled well
@abotalov
Both start and end tags of html / head / body / colgroup / tbody elements can't be omitted
abotalov commented on issue jnicklas/capybara#1508
@abotalov

It's possible using https://github.com/jarib/browsermob-proxy-rb (I haven't used it for 9 months though)