Fixed the nickname usage, ordering of parameters to emit_to_room() and improper echo to the sender #25

Merged
merged 1 commit into from May 7, 2012

Conversation

Projects
None yet
3 participants

Additional changes to fix #12

  • Nicknames are now echo'd properly in the chat window.
  • Messages from one user to another are transmitted with emit_to_room()
  • Upon new users joining, Nicknames are now announced

Thanks go to @mruser

It is not obvious that the semantics of emit_to_room should be "send to everyone in the room except for myself", especially when the semantics of broadcast_event follow the convention that broadcast mean send to everyone including myself.
Perhaps this should be configurable in RoomsMixin, or it should be an argument to emit_to_room (possibly an optional named argument using **kwargs), because this is a common use case.

@abourget abourget added a commit that referenced this pull request May 7, 2012

@abourget abourget Merge pull request #25 from dkoneill/master
Fixed the nickname usage, ordering of parameters to emit_to_room() and improper echo to the sender
3f5e94e

@abourget abourget merged commit 3f5e94e into abourget:master May 7, 2012

Owner

abourget commented May 7, 2012

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment