Ensure extensions are in names #46 #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When creating a VirtualCodebase from a scan, make sure that the extension is in the file name before creating the Resource
* Add test
Signed-off-by: Jono Yang <jyang@nexb.com>
Member
|
@JonoYang is ScanCode.io returning filenames without extensions? this would be a bug there then. |
Member
Author
|
Closing this, as we now set extensions in filenames on scancode.io: https://github.com/nexB/scancode.io/blob/main/scanpipe/migrations/0019_auto_20220804_1836.py |
AyanSinhaMahapatra
pushed a commit
to AyanSinhaMahapatra/commoncode
that referenced
this pull request
Feb 14, 2025
Handle as_text correctly in cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
VirtualCodebase._populate()to append a Resources extension to its name before it is created, if the extension is not already present in the name.