Fixes in Debian Index Visitor function. #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzip file content will read as text instead of bytes. String version Will be passed instead of Version Object. Signed-off-by: Jay <jaykumar20march@gmail.com>
JonoYang
requested changes
Feb 13, 2023
Member
JonoYang
left a comment
JonoYang
left a comment
There was a problem hiding this comment.
How did you test this fix? Did you run the visitor to visit the Debian repos to see if the get_uris method worked? I would like to try this out.
| from packagedcode import models as scan_models | ||
| from packageurl import PackageURL | ||
|
|
||
| import debutils |
Member
There was a problem hiding this comment.
debutils is imported but not used?
Contributor
Author
@JonoYang the PR is Incomplete, i should have converted it to draft. I still haven't done anything about the |
Contributor
Author
|
Closing This PR, New PR #41 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Gzip file content will read as text instead of bytes. String version Will be passed instead of Version Object.
Signed-off-by: Jay jaykumar20march@gmail.com