Skip to content

Add FederatedCode integration #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 20, 2024
Merged

Add FederatedCode integration #557

merged 8 commits into from
Dec 20, 2024

Conversation

@keshav-space
Copy link
Member

@keshav-space keshav-space commented Dec 13, 2024 •
edited
Loading

@keshav-space keshav-space self-assigned this Dec 13, 2024
@keshav-space keshav-space force-pushed the federatedcode-integration branch from aeb0539 to 3208a00 Compare December 16, 2024 20:03
This was referenced Dec 17, 2024
Closed
Closed
pombredanne
pombredanne requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great ... Can you confirm that you change is not breaking the head with @JonoYang changes for scancode.io?

setup.cfg Outdated
purl2vcs == 2.0.0
univers == 30.12.1
scancodeio @ git+https://github.com/aboutcode-org/scancode.io.git@3eeb0c040c6077d773680b59da6fa283ba1500bf
scancodeio @ git+https://github.com/aboutcode-org/scancode.io@bumb-hashid
Copy link
Member

@pombredanne pombredanne Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space are you sure you branch also covers the commit above?
@JonoYang ping

Copy link
Member

@pombredanne pombredanne Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space aboutcode-org/scancode.io#1479 is merged now. Can you update your PR and also take into account that: aboutcode-org/scancode.io@3eeb0c0 and then sync with @JonoYang ?

Copy link
Member Author

@keshav-space keshav-space Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne aboutcode-org/scancode.io@3eeb0c0 belongs to aboutcode-org/scancode.io#1466 which is already merged. I will update the PR to use the scancode.io@main i.e aboutcode-org/scancode.io@e1607c7

@keshav-space
Remove pycache on make clean
bc74904 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Add model and endpoint for PackageActivity
d3fa477 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Add endpoint to listen for activity updates
e975195 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Use .env to config FederatedCode host
1ab9fe5 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Bump scancode.io
4d0cd12 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Use latest scancodeio
8240e82 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Fix docs generation issue introduced in #550
1781f80 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space keshav-space force-pushed the federatedcode-integration branch from 1d0a52d to 1781f80 Compare December 18, 2024 17:45
JonoYang
JonoYang requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshav-space The code looks fine, just needs some tests for the new API endpoints. 👍

@keshav-space
Copy link
Member Author

keshav-space commented Dec 19, 2024

The code looks fine, just needs some tests for the new API endpoints. 👍

@JonoYang Done!

@keshav-space
Add tests for AP package activity endpoints
ab2c76f 
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space keshav-space force-pushed the federatedcode-integration branch from 08d6994 to ab2c76f Compare December 19, 2024 17:09
@JonoYang
Copy link
Member

JonoYang commented Dec 20, 2024

@keshav-space Thanks! merging

@JonoYang JonoYang merged commit e66112d into main Dec 20, 2024
7 checks passed
@JonoYang JonoYang deleted the federatedcode-integration branch December 20, 2024 18:25
JonoYang added a commit that referenced this pull request Apr 14, 2025
@JonoYang
Merge pull request #557 from aboutcode-org/federatedcode-integration
998e5f9 
Add FederatedCode integration
@pombredanne pombredanne moved this from Done to Validated in 02-FederatedCode - Software metadata May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne requested changes

@JonoYang JonoYang JonoYang requested changes

Assignees

@keshav-space keshav-space

Labels

None yet

Projects

No open projects
02-FederatedCode - Software metadata
Status: Validated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keshav-space @JonoYang @pombredanne