From fc01392eaebeac2c1ee88fded8314cd63766d51d Mon Sep 17 00:00:00 2001
From: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Date: Mon, 21 Sep 2020 15:06:49 +0530
Subject: [PATCH] :wrench: Fix UI bug with vulnerability search view's
 pagination

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
---
 vulnerabilities/forms.py                       | 2 +-
 vulnerabilities/templates/vulnerabilities.html | 4 ++--
 vulnerabilities/views.py                       | 9 +++++----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/vulnerabilities/forms.py b/vulnerabilities/forms.py
index ac69d05dd..b075282b2 100644
--- a/vulnerabilities/forms.py
+++ b/vulnerabilities/forms.py
@@ -53,4 +53,4 @@ class PackageForm(forms.Form):
 
 class CVEForm(forms.Form):
 
-    cve_id = forms.CharField(widget=forms.TextInput(attrs={"placeholder": "vulnerability id"}))
+    vuln_id = forms.CharField(widget=forms.TextInput(attrs={"placeholder": "vulnerability id"}))
diff --git a/vulnerabilities/templates/vulnerabilities.html b/vulnerabilities/templates/vulnerabilities.html
index 6eaeb39fc..532a50837 100644
--- a/vulnerabilities/templates/vulnerabilities.html
+++ b/vulnerabilities/templates/vulnerabilities.html
@@ -12,7 +12,7 @@ <h1 class="title">
      <form action="{% url 'vulnerability_search' %}" method="get">
       {% load widget_tweaks %}
       <div class="field is-horizontal">
-        {{form.cve_id|add_class:"input"}}
+        {{form.vuln_id|add_class:"input"}}
         <button class="button is-success", type="submit">
           Search
         </button>
@@ -25,7 +25,7 @@ <h1 class="title">
     <section class="section is-medium has-text-centered">
       <div class="container">
         <h1 class="title" id="results">Results of your query "{{searched_for}}"</h1>
-        <h3 class="subtitle" id="results">Total {{vulnerabilities|length}} results</h3>
+        <h3 class="subtitle" id="results">Total {{result_size}} results</h3>
       </div>
     </section>
 
diff --git a/vulnerabilities/views.py b/vulnerabilities/views.py
index e7154ef58..fd02b5023 100644
--- a/vulnerabilities/views.py
+++ b/vulnerabilities/views.py
@@ -75,17 +75,18 @@ def get(self, request):
         if request.GET:
             vulnerabilities = self.request_to_queryset(request)
             pages = Paginator(vulnerabilities, 50)
+            result_size = pages.count
             vulnerabilities = pages.get_page(int(self.request.GET.get("page", 1)))
             context["vulnerabilities"] = vulnerabilities
-            context["searched_for"] = request.GET.get("cve_id")
+            context["searched_for"] = request.GET.get("vuln_id")
+            context["result_size"] = result_size
 
         return render(request, self.template_name, context)
 
     @staticmethod
     def request_to_queryset(request):
-        if request.GET["cve_id"]:
-            cve_id = request.GET["cve_id"]
-            return models.Vulnerability.objects.filter(cve_id__contains=cve_id)
+        vuln_id = request.GET["vuln_id"]
+        return models.Vulnerability.objects.filter(cve_id__contains=vuln_id)
 
 
 class PackageUpdate(UpdateView):