Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private classes do not allow extension #381

Closed
xtinagodwin opened this issue Jul 14, 2015 · 2 comments
Closed

Private classes do not allow extension #381

xtinagodwin opened this issue Jul 14, 2015 · 2 comments
Labels

Comments

@xtinagodwin
Copy link

My project requires integration with the Twitter Ads API and the Twitter TON API, which I have accomplished by extending TwitterOauth and writing a tiny bit of code. Is it possible to make the oAuthRequest function and $response member variables protected instead of private? The affected file is src/TwitterOauth.php on lines 265 and 23.

I made these changes locally, however I would love it if these changes could be integrated into the project so a composer update doesn't break things for me.

Thanks for reading!

@miguelmora76
Copy link

+1. That would be very useful! This would really help with something similar that we're doing on our project.

@abraham abraham added this to the v2.0 milestone Feb 23, 2017
@abraham abraham removed this from the v2.0 milestone Jul 3, 2018
@abraham
Copy link
Owner

abraham commented Jul 19, 2021

Release 3.1.0 allows overriding apiUrl and setting custom API hosts. It should work until #684 is implemented.

@abraham abraham closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants