Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Ads API #382

Closed
abraham opened this issue Jul 17, 2015 · 6 comments
Closed

Support the Ads API #382

abraham opened this issue Jul 17, 2015 · 6 comments

Comments

@abraham
Copy link
Owner

abraham commented Jul 17, 2015

This would probably be a breaking change and would likely result in an API that looks something like this.

$twt = new TwitterOAuth(...);
$ads = $twt->ads->get(...); // Ads request
$statuses = $twt->api->get(...); // REST API request
@esthezia
Copy link

Hi Abraham! For now, you could only change TwitterOAuth.php and access API_HOST by static::API_HOST instead of self::API_HOST, and the same for API_VERSION. This, to be able to overwrite these in an extending class. And this seems to suffice to be able to use this library for working with Ads API.

I've done this locally and it works with only these changes made.

@rossbg
Copy link

rossbg commented Nov 17, 2015

Hello,

I think this should be top pri :) Any timeframe to share? Thanks :)

@idlikesometea
Copy link

Exactly what should I change to connect to ADS Api? I've changed the self to statics and the API_HOST to https://ads-api.twitter.com but i keep getting a ROUTE_NOT_FOUND error. Any clue? Thanks in advance

@rossbg
Copy link

rossbg commented Nov 24, 2015

you should change API_VERSION to "0"

@idlikesometea
Copy link

Thanks!

@abraham abraham added this to the v2.0 milestone Feb 23, 2017
@abraham
Copy link
Owner Author

abraham commented Jul 3, 2018

Moving to #684

@abraham abraham closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants