New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON POST bodies #581

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@abraham
Owner

abraham commented Jun 30, 2017

  • Cleanup
  • Add tests
@Nicolapps

This comment has been minimized.

Nicolapps commented Sep 12, 2017

Can I provide any kind of help with this PR ?

@mpociot

This comment has been minimized.

mpociot commented Oct 25, 2017

@abraham can I help you with this PR? Would love to use your library in combination with BotMan. The PR changes work perfectly for me.

@mpociot

This comment has been minimized.

mpociot commented Feb 20, 2018

Hi @abraham - you're probably extremely busy, but I still wanted to ask you if I can help you with this or if you happen to know a timeframe at which you want to look into this PR.

Thank you!

@mathiasmoeller

This comment has been minimized.

mathiasmoeller commented Mar 27, 2018

Are there any news on the json feature?

@kinoute

This comment has been minimized.

Contributor

kinoute commented Apr 8, 2018

Interested by this as well. The direct_messages/new endpoint will be deprecated on June 19th.

https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/guides/direct-message-migration

@mpociot You plan to add Twitter support to BotMan? That would be awesome!

@mpociot

This comment has been minimized.

mpociot commented Apr 26, 2018

@kinoute Yes, I already created a driver for Twitter: https://github.com/botman/driver-twitter
Just waiting for this PR to get merged :)

@TheDigitalOrchard

This comment has been minimized.

TheDigitalOrchard commented May 4, 2018

I submitted a pull request to address the issues reported by the code review.

This was referenced Jul 1, 2018

@abraham abraham closed this in #675 Jul 2, 2018

@abraham abraham deleted the json-post branch Jul 2, 2018

@abraham

This comment has been minimized.

Owner

abraham commented Jul 3, 2018

This is now released in v0.9.

sololance added a commit to sololance/driver-twitter that referenced this pull request Aug 12, 2018

Update readme by removing notes
JSON POST bodies PR has been merged abraham/twitteroauth#581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment