From 88bc2aebf685a18e5e96bb889f555d1f1d63f719 Mon Sep 17 00:00:00 2001 From: Emil Ong Date: Wed, 26 Aug 2020 12:14:54 -0700 Subject: [PATCH] Use semver for version comparison --- lib/file/getFileBlobAsync.js | 3 ++- package.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/file/getFileBlobAsync.js b/lib/file/getFileBlobAsync.js index 0f2ac35..7a84570 100644 --- a/lib/file/getFileBlobAsync.js +++ b/lib/file/getFileBlobAsync.js @@ -1,4 +1,5 @@ import { extname } from 'path'; +import semver from 'semver'; import { ENCODING, FILE_EXTENSION } from './constants'; @@ -12,7 +13,7 @@ let wrapBlob = blob => { return Cypress.Promise.resolve(blob); }; -if (Cypress.version < '5.0.0') { +if (semver.lt(Cypress.version, '5.0.0')) { wrapBlob = blob => blob; } diff --git a/package.json b/package.json index 6547cae..5bcb142 100644 --- a/package.json +++ b/package.json @@ -46,6 +46,7 @@ "cypress": ">3.0.0" }, "dependencies": { - "mime": "^2.4.4" + "mime": "^2.4.4", + "semver": "^7.3.2" } }