Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 doesn't support [tool.flake8] #72

Closed
jelmer opened this issue Mar 8, 2023 · 3 comments · Fixed by #76
Closed

flake8 doesn't support [tool.flake8] #72

jelmer opened this issue Mar 8, 2023 · 3 comments · Fixed by #76
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jelmer
Copy link

jelmer commented Mar 8, 2023

flake8 doesn't support pyproject.toml yet - see PyCQA/flake8#234

Not sure if it fits with the project, but it'd be great to be able to generate either a minimal setup.cfg with things that can't be migrate or to e.g. populate a .flake8 or tox.ini file with the flake8 settings. Or if those aren't an option, warn the user that part of their config won't be effective.

@abravalheri
Copy link
Owner

Hi @jelmer, currently this tool will use a "best effort guess" when it comes up with a section it does not have a plugin for. This is kind of intended because the project primary use is setup.cfg but it is not restricted to it.

That is why the docs recommend the user to review the configuration before using it.

We can add something in the logs every time that the "best effort guess" is used. I will have a look on this when I have some time. If any other member of the community would like to give it a go, PRs are also welcomed.

@abravalheri abravalheri added enhancement New feature or request help wanted Extra attention is needed labels Mar 8, 2023
@jelmer
Copy link
Author

jelmer commented Mar 8, 2023

Yeah, I appreciate that. Even with that in mind though, it'd be great for the tool to provide a hint to the user.

@abravalheri
Copy link
Owner

@jelmer in #76 I am giving my best shot, given the circumstances (and trying to avoid breaking the downstream users' test suite with strict warning filters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
2 participants