Skip to content

Andrey Breslav
abreslav

Organizations

@JetBrains
Apr 25, 2016
@abreslav

But a coroutine becomes something different from a "normal" callback only when a suspension call is used, otherwise once the code inside starts ru…

Apr 25, 2016
@abreslav

True, but at least it's an indication that this is not a normal snipped of code but a coroutine. For the record, an option here is to indicate th…

Apr 25, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

What wording we use in the code is hardly a justification for saying something ambiguous in public docs :) "Value" is something rather unclear in t…

Apr 25, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

Well, maybe, but the rules of checking types in the RHS of a typealias are dfferent from those of normal types

Apr 25, 2016
@abreslav

Also, if the coroutine allows to reset the state or something, it could be hard to understand why the execution is not reaching some code. This c…

Apr 24, 2016
@abreslav

I think it can be helpful to list what the benefits of this communication is in order to make a sound decision. One thing that comes to mind: the…

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

Added some comments to the diff

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

Why?

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

How does it matter, if this function is not in the source code anyways?

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

Why not the property declaration?

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

Ok, now I understand what you assumed above. It means that at some properties we will stop twice: first for initializer/delegate, then for attachTo.…

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

or each of secondary constructors Is this for the case when no primary constructor is defined?

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

It will be triggered on delegate expression first

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

What if the next property has no attachTo, but has a non-trivial initializer that the debugger has to stop on, or next follows an init block? I bel…

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

No default parameters, no varargs

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

I was able to decrypt what this phrase implies, but most readers won't

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

This rule is surprising and needs justification/clarification

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

wrt to type of instance being the default type of the containing class. What if the property is a not a member? We must say explicitly that null as…

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

We could allow returning a (potentially different) instance of DelegateType, to facilitate customizing delegate object upon creation

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

I think we should work some more on the title. Options off the top of my head: Attachment handlers for delegated properties Creation handlers for …

Apr 22, 2016
abreslav commented on commit Kotlin/KEEP@e37c89e712
@abreslav

The comment has since been removed.

Apr 22, 2016
abreslav commented on commit Kotlin/KEEP@e37c89e712
@abreslav

The comment has since been removed.

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#6
@abreslav

We'd still need an issue for discussion

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

Review finished, some changes requested

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

An example needed, IMO

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

I'd say "expression" and not "value"

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

I think we should add an example about Array2D<String> being not assignable to Array2D<*>

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

There's a caveat here: typalias A<T> = NN<T> // is this type well-formed? We need special rules for well-formedness wrt parameters of type aliase…

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

I think we should mention explicitly in the text that constraints and variance are not allowed

Apr 22, 2016
abreslav commented on pull request Kotlin/KEEP#7
@abreslav

the public discussion has show that this is reason is rather weak, and provokes unnecessary discussion. We can use proper reasoning to justify lack…

Something went wrong with that request. Please try again.