Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support handling crashes in lxc containers #810

Merged
merged 1 commit into from Apr 7, 2014
Merged

Support handling crashes in lxc containers #810

merged 1 commit into from Apr 7, 2014

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Apr 7, 2014

This changes the behaviour of ccpp-hook to respect
global PID. Now it chroots into the container environment
before attempting to save data about the crashing process
and contacting abrtd running in guest.

Previously, the crash was handled by ccpp-hook on the host
which saved data about incorrect process due to global/local
PID mismatch.

Closes #809.

Signed-off-by: Richard Marko rmarko@fedoraproject.org

This changes the behaviour of ccpp-hook to respect
global PID. Now it chroots into the container environment
before attempting to save data about the crashing process
and contacting abrtd running in guest.

Previously, the crash was handled by ccpp-hook on the host
which saved data about incorrect process due to global/local
PID mismatch.

Closes #809.

Signed-off-by: Richard Marko <rmarko@fedoraproject.org>
@jfilak
Copy link
Contributor

jfilak commented Apr 7, 2014

Good job! Would it be possible to develop a test case for this pull request?

@sorki
Copy link
Contributor Author

sorki commented Apr 7, 2014

Test case would have to create new lxc container (downloading and installing minimal set of packages) or use readonly rootfs of the host, neither seems like a good option to me.

Existing test cases at least check if this breaks anything in case of handling normal crashes.

@jfilak
Copy link
Contributor

jfilak commented Apr 7, 2014

OK. I've verified that this pull request does not break handling of normal crashes.

jfilak added a commit that referenced this pull request Apr 7, 2014
Support handling crashes in lxc containers
@jfilak jfilak merged commit f0ef180 into master Apr 7, 2014
@jfilak jfilak deleted the gh809_lxc branch October 3, 2014 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for handling crashes in lxc containers
2 participants