Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Support handling crashes in lxc containers #810
Conversation
|
Good job! Would it be possible to develop a test case for this pull request? |
|
Test case would have to create new lxc container (downloading and installing minimal set of packages) or use readonly rootfs of the host, neither seems like a good option to me. Existing test cases at least check if this breaks anything in case of handling normal crashes. |
|
OK. I've verified that this pull request does not break handling of normal crashes. |
added a commit
that referenced
this pull request
Apr 7, 2014
jfilak
merged commit f0ef180
into
master
Apr 7, 2014
jfilak
deleted the
gh809_lxc
branch
Oct 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sorki commentedApr 7, 2014
This changes the behaviour of ccpp-hook to respect
global PID. Now it chroots into the container environment
before attempting to save data about the crashing process
and contacting abrtd running in guest.
Previously, the crash was handled by ccpp-hook on the host
which saved data about incorrect process due to global/local
PID mismatch.
Closes #809.
Signed-off-by: Richard Marko rmarko@fedoraproject.org