Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port the debuginfo downloader to dnf #291

Closed
jfilak opened this issue Oct 6, 2014 · 3 comments · Fixed by #336
Closed

port the debuginfo downloader to dnf #291

jfilak opened this issue Oct 6, 2014 · 3 comments · Fixed by #336
Milestone
Fedora 22

Comments

@jfilak
Copy link
Contributor

jfilak commented Oct 6, 2014

Fedora is to replace yum by dnf in F22 [1]

1: http://fedoraproject.org/wiki/Changes/ReplaceYumWithDNF
@jfilak jfilak added this to the Fedora 22 milestone Oct 14, 2014
@jfilak
Copy link
Contributor Author

jfilak commented Nov 5, 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1156485

@jfilak
Copy link
Contributor Author

jfilak commented Nov 26, 2014

Here are some resources recommended by @rholy:

https://github.com/rholy/dnf/blob/master-RhBug-1138096-fix/doc/examples/install_extension.py
http://dnf.readthedocs.org/en/latest/api.html
http://dnf.readthedocs.org/en/latest/api_queries.html
https://github.com/rpm-software-management/dnf-plugins-core/blob/master/plugins/download.py
http://dnf.readthedocs.org/en/latest/api_repos.html
https://github.com/rpm-software-management/dnf-plugins-core/blob/master/plugins/debuginfo-install.py

@ghost
Copy link

ghost commented Nov 26, 2014

The important truncated information is that some plugins may use some undocumented methods. Please don't use them. If needed, let us know and we'll add them to the API. I.e. the "download" plugin now uses a localPkg method that is not part of API. This method is crucial for you. We'll add it to the API but we'll probably change its name. It would be nice if you could file a Bugzilla asking for a method providing path to the downloaded package so we won't forget and you can track the progress.

jfilak pushed a commit that referenced this issue Mar 5, 2015
build: create reportclient sub-directory
c024366 
for easier debugging. Now you can configure your PYTHONPATH to find
reportclient module in src/client-python.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportpython: introduce DNF debug info downloader
a5d821a 
DebugInfoDownload is an abstract template class.

DNFDebugInfoDownload and YumDebugInfoDownload implements the abstract
methods.

I did this in hope to use this schema for adding support of libzypp on
OpenSUSE in the future.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportclient: return full path to downloaded debuginfo packages
9036031 
There is no need to try to reconstruct the full path to the downloaded
package when both yum and dnf already know it. Also unpack_rpm()
function appeared to me a bit overloaded because I think this
function should have just one responsibility and that is to unpack
rpm.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportclient: introduce DNF debug info downloader
7a1f41e 
DebugInfoDownload is an abstract template class.

DNFDebugInfoDownload and YumDebugInfoDownload implements the abstract
methods.

I did this in hope to use this schema for adding support of libzypp on
OpenSUSE in the future.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportclient: return full path to downloaded debuginfo packages
f8aaf2b 
There is no need to try to reconstruct the full path to the downloaded
package when both yum and dnf already know it. Also unpack_rpm()
function appeared to me a bit overloaded because I think this
function should have just one responsibility and that is to unpack
rpm.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
@jfilak jfilak mentioned this issue Mar 5, 2015
Merged
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportclient: introduce DNF debug info downloader
5f8c566 
DebugInfoDownload is an abstract template class.

DNFDebugInfoDownload and YumDebugInfoDownload implements the abstract
methods.

I did this in hope to use this schema for adding support of libzypp on
OpenSUSE in the future.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
reportclient: return full path to downloaded debuginfo packages
70f4294 
There is no need to try to reconstruct the full path to the downloaded
package when both yum and dnf already know it. Also unpack_rpm()
function appeared to me a bit overloaded because I think this
function should have just one responsibility and that is to unpack
rpm.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Mar 5, 2015
dnfdebuginfo: check the status of downloading
39caef1 
DonwloadCallback.end() has to check the status argument because DNF
(librepo) calls this callback for failures too.

Related to #291

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Fedora 22
Development

Successfully merging a pull request may close this issue.

port to dnf abrt/libreport
1 participant
@jfilak