Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed exponential notation when parsing numbers, closes #173 #174

Merged
merged 2 commits into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@odino
Copy link
Collaborator

commented Feb 8, 2019

⧐  1e-10
0.0000000001
⧐  '1e-10'.json()
0.0000000001

fixes #173

@ntwrick do you mind double checking this when you have time? Rushed this in a few minutes so there might be something I've been missing, would ❤️ a 2nd opinion :)

Allowed exponential notation when parsing numbers, closes #173
```
⧐  1e-10
0.0000000001
⧐  '1e-10'.json()
0.0000000001
```

@odino odino added this to the 1.2.x milestone Feb 8, 2019

@odino odino requested a review from ntwrick Feb 8, 2019

@ntwrick

ntwrick approved these changes Feb 9, 2019

Copy link
Contributor

left a comment

Looks solid. Nice solution.

@odino odino merged commit a70ed8e into 1.2.x Feb 10, 2019

1 check passed

coverage/coveralls Coverage increased (+0.1%) to 73.275%
Details

@odino odino deleted the parse-exponential-notation branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.