Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty string to json will not panic now, closes #222 #226

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@mingwho
Copy link
Contributor

commented May 15, 2019

We will check if str is empty first before using str[0]

@odino

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

Boom! 🚀

Thanks!

@odino odino merged commit ae43886 into abs-lang:1.4.x May 15, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.008%) to 70.785%
Details
@odino

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

Note to self: this should be backported to 1.3.

@odino odino added this to the 1.4.x milestone May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.