Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

args() function #305

Open
wants to merge 7 commits into
base: 1.9.x
from

Conversation

@sysread
Copy link

sysread commented Nov 27, 2019

Adds a secondary syntax for calling env to set an environment variable. Also adds a new routine, validateVarArgs, to functions.go that validates multiple sets of calling semantics.

Jeff Ober and others added 6 commits Nov 7, 2019
Returns the number of arguments to the current script, including
the script itself.
@odino

This comment has been minimized.

Copy link
Collaborator

odino commented Nov 28, 2019

LGTM. Can you send this PR to the 1.9.x branch though?

@sysread

This comment has been minimized.

Copy link
Author

sysread commented Nov 29, 2019

@odino

This comment has been minimized.

Copy link
Collaborator

odino commented Nov 29, 2019

@odino

This comment has been minimized.

Copy link
Collaborator

odino commented Dec 2, 2019

BTW lmk if you need some more time -- this week I intend to release 1.9. It would be great to include this feature but if you need some more time I'll go ahead and prepare a release, and include this in 1.10. No pressure, lmk!

@sysread sysread changed the base branch from 1.8.x to 1.9.x Dec 2, 2019
@sysread

This comment has been minimized.

Copy link
Author

sysread commented Dec 2, 2019

I changed the pr target and resolved the conflicts. If you prefer, I can cherry pick to 1.9.x and submit as a new PR instead, although we'd lost the conversation history here.

@odino odino changed the title 1.8.x args() function Dec 2, 2019
@odino

This comment has been minimized.

Copy link
Collaborator

odino commented Dec 2, 2019

This is perfect, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.