abseil-cpp\CMake\AbseilHelpers.cmake #796
Labels
Comments
logThe following is the log when compiled as a third-party library The following is the log when abseil is compiled as the main project |
ulinzeng
changed the title
Merged
absl-federation-github
pushed a commit
that referenced
this issue
Nov 13, 2020
-- a1b28d83d60f96e14487f093566f12ba07f92732 by Mark Barolak <mbar@google.com>: Import of CCTZ from GitHub. PiperOrigin-RevId: 342270204 -- 3d99c08b7e2ee23050f64965f09881b54821cdd0 by Mark Barolak <mbar@google.com>: Fix a Windows DLL breakage that is causing all sub-libraries to be compiled as DLL dependencies instead of stand-alone DLLs. See #796 for the bug report. Import of #797 PiperOrigin-RevId: 341892182 GitOrigin-RevId: a1b28d83d60f96e14487f093566f12ba07f92732 Change-Id: I7d70f07492bfa9b657ec280a4f005c1ee893594c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When I use Abseil as a third-party library with source code integration, I want to compile a dynamic library under Windows. At this time, the problem arises. The target in abseil will also be compiled as dll_dep, and I have set BUILD_SHARED_LIBS=ON. Through debugging, I found that it turned out to be the reason for the setting of _NAME. When abseil is used as a third-party library, NAME will be set to "absl${ABSL_CC_LIB_NAME}", which is judged to be not part of the dll in the subsequent absl_internal_dll_contains function. These targets are thus identified as dll_dep, and then compiled with the ABSL_CONSUME_DLL macro definition attached, resulting in compilation errors.
The text was updated successfully, but these errors were encountered: