Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absl::container Windows VS 15.8 (fix #192) #194

Merged
merged 1 commit into from
Oct 31, 2018
Merged

absl::container Windows VS 15.8 (fix #192) #194

merged 1 commit into from
Oct 31, 2018

Conversation

Mizux
Copy link
Contributor

@Mizux Mizux commented Oct 17, 2018 •
edited
Loading

Fix for #192

@zhangxy988
Copy link
Contributor

@Mizux Do you mind separating the fix for absl/containers into a separate PR from the CMake changes? That way we can review them separately and be more productive.

@Mizux
Copy link
Contributor Author

Mizux commented Oct 19, 2018 •
edited
Loading

just git rebase -i the branch there is:

note: I have my branch master in my abseil-cpp fork with all the fix and the CI running....

@Mizux Mizux changed the title Few CMake based build Windows fix absl::container Windows VS 15.8 fix Oct 19, 2018
@Mizux Mizux changed the title absl::container Windows VS 15.8 fix absl::container Windows VS 15.8 (fix #192) Oct 19, 2018
This was referenced Oct 19, 2018
Open
Closed
@Mizux
Copy link
Contributor Author

Mizux commented Oct 24, 2018

DISCLAIMER: We should wait for #197 (Add CMake CI support) and #196 (Alignment conformance fix) before.

This issue may have disappear on HEAD (Alignment conformance error hide it on v15.8) -> I will be happy to look at CI log to verify if it's still present once alignment patch is submit.

@aaniin
Copy link

aaniin commented Oct 28, 2018

Hi @Mizux ,
Thanks for this fix! I needed it to compile tensorflow (which includes abseil-cpp) with Visual Studio 2017 (v15.8.8)

@zhangxy988 zhangxy988 requested review from zhangxy988 and removed request for JonathanDCohen October 30, 2018 17:59
@zhangxy988 zhangxy988 merged commit a705aa7 into abseil:master Oct 31, 2018
absl-federation-github pushed a commit that referenced this pull request Oct 31, 2018
@mattcalabrese-google
Export of internal Abseil changes.
cc8dcd3 
--
9e8aa654630015ea8221703b0ea10dd1a47a848f by Abseil Team <absl-team@google.com>:

Fix typo

PiperOrigin-RevId: 219474910

--
b1621572fb5a326642766f9f0f16abc3620dd6e8 by Xiaoyi Zhang <zhangxy@google.com>:

Applies #194 to fix raw_hash_map
build issues for Windows VS 15.8.

PiperOrigin-RevId: 219473484

--
a61df296bc5449261c6deccb6410df83d560d210 by Jon Cohen <cohenjon@google.com>:

Remove reference to ABSL_COMPILE_CXXFLAGS in our cmakelists files.  It wasn't used, but we will soon instead use an INERFACE target with target_compile_options for the compile options needed for Abseil.

PiperOrigin-RevId: 219352641

--
0d9536a26c03229df3e782e78a8211e450259af2 by Abseil Team <absl-team@google.com>:

Add missing dependencies on base:core_headers

PiperOrigin-RevId: 219320098

--
5693e836e4ec4ce23315f3a7846c12c64cf3d5ab by Abseil Team <absl-team@google.com>:

Remove dynamic_annotations from core_headers, and add core_headers to CMakeLists.

PiperOrigin-RevId: 219306959
GitOrigin-RevId: 9e8aa654630015ea8221703b0ea10dd1a47a848f
Change-Id: Ie52b9fa7ab1285b6846ceea5503caf744e7303d8
@sesmith177 sesmith177 mentioned this pull request Nov 2, 2018
Merged
mattklein123 pushed a commit to envoyproxy/envoy that referenced this pull request Nov 2, 2018
@sesmith177 @mattklein123
build: bump abseil-cpp to cc8dcd3 (#4948)
e3929e0 
This picks up a fix for a bug where abseil-cpp would not compile with
Visual Studio 15.8. See:

abseil/abseil-cpp#192
abseil/abseil-cpp#194

Signed-off-by: Yael Harel <yharel@pivotal.io>
Signed-off-by: Sam Smith <sesmith177@gmail.com>
absl-federation-github pushed a commit that referenced this pull request Dec 17, 2018
@ahedberg
Creation of LTS branch "lts_2018_12_18"
fcb1045 
  - 44b0faf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 926bfeb Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 13327de Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3088e76 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f6ae816 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a06c4a1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7b46e1d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 070f6e4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7990fd4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f951790 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - cc8dcd3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a705aa7 Merge pull request #194 from Mizux/windows by Xiaoyi Zhang <zhangxy988@gmail.com>
  - a4c3fff Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0117457 Merge pull request #201 from ccawley2011/fix-byteswap by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com>
  - f86f941 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 94c298e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0884a6a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c16d555 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 45221cc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2019e17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5b70a89 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a00bdd1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f340f77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 445998d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e821380 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f21d187 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5441bbe Fix code snippet in comment (#174) by Loo Rong Jie <loorongjie@gmail.com>
  - 5aae0cf Fix CMake build (#173) by Stephan Dollberg <stephan.dollberg@gmail.com>
  - 48cd2c3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e291c27 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e01d955 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8ff1374 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0245191 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 921fd5c Merge pull request #166 from rongjiecomputer/cmake-test by Gennadiy Civil <gennadiycivil@users.noreply.github.com>
  - fb46222 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c075ad3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0f4bc96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6c7e5ff Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d6df769 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 28080f5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9c987f4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5e7d459 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bed5bd6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - fefc836 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d8cfe9f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ad5c960 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 86f0fe9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f0f15c2 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 29ff6d4 Removed "warning treated as error" flag from MSVC (#153) by vocaviking <vocaviking@users.noreply.github.com>
  - 083d04d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bea85b5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8f96be6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 92e07e5 Merge pull request #152 from clnperez/fix-multi-defines-p... by Derek Mauro <761129+derekmauro@users.noreply.github.com>
  - 2125e64 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9acad86 Merge pull request #150 from OlafvdSpek/patch-2 by Jonathan Cohen <cohenjon@google.com>
  - c2e00d3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9e06068 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7aa411c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2c5af55 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 44aa275 Merge pull request #143 from rongjiecomputer/kernel by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 42f22a2 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b973bc5 Merge pull request #139 from siepkes/smartos-support by ahedberg <ahedberg@google.com>
  - e0def74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f826f1d Merge pull request #138 from edbaunton/remove-deprecated-... by ahedberg <ahedberg@google.com>
  - 7b50a4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a5030ca Merge pull request #144 from rongjiecomputer/winsock2 by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 0268795 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8f612eb Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 134496a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ba8d6cf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - be1e84b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 16ac2ec Merge pull request #134 from rongjiecomputer/cmake by Alex Strelnikov <strel@google.com>
  - 7efd8dc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 87a4c07 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 4491d60 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 44b0faf
Change-Id: I2c427b5b41b2d34101922048b00f3d9dafcb498d
@Mizux Mizux deleted the windows branch January 3, 2019 14:43
4s5t2os41n added a commit to 4s5t2os41n/abseil-cpp that referenced this pull request Jul 4, 2024
@4s5t2os41n @mattcalabrese-google
Export of internal Abseil changes.
26cedbf 
--
9e8aa654630015ea8221703b0ea10dd1a47a848f by Abseil Team <absl-team@google.com>:

Fix typo

PiperOrigin-RevId: 219474910

--
b1621572fb5a326642766f9f0f16abc3620dd6e8 by Xiaoyi Zhang <zhangxy@google.com>:

Applies abseil/abseil-cpp#194 to fix raw_hash_map
build issues for Windows VS 15.8.

PiperOrigin-RevId: 219473484

--
a61df296bc5449261c6deccb6410df83d560d210 by Jon Cohen <cohenjon@google.com>:

Remove reference to ABSL_COMPILE_CXXFLAGS in our cmakelists files.  It wasn't used, but we will soon instead use an INERFACE target with target_compile_options for the compile options needed for Abseil.

PiperOrigin-RevId: 219352641

--
0d9536a26c03229df3e782e78a8211e450259af2 by Abseil Team <absl-team@google.com>:

Add missing dependencies on base:core_headers

PiperOrigin-RevId: 219320098

--
5693e836e4ec4ce23315f3a7846c12c64cf3d5ab by Abseil Team <absl-team@google.com>:

Remove dynamic_annotations from core_headers, and add core_headers to CMakeLists.

PiperOrigin-RevId: 219306959
GitOrigin-RevId: 9e8aa654630015ea8221703b0ea10dd1a47a848f
Change-Id: Ie52b9fa7ab1285b6846ceea5503caf744e7303d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxy988 zhangxy988 zhangxy988 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mizux @zhangxy988 @aaniin @googlebot