Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate object/interfaces implement all transitive interfaces #1127

Merged
merged 5 commits into from Nov 26, 2021
Merged

Validate object/interfaces implement all transitive interfaces #1127

merged 5 commits into from Nov 26, 2021

Conversation

maartenvanvliet
Copy link
Contributor

@maartenvanvliet maartenvanvliet commented Nov 25, 2021 •
edited

See #1080 for a full description

  • adds a type reference check to see whether interfaces on interfaces exist
  • adds a check to ensure that an object/interface implements all interfaces, also interfaces it transitively has

@tlvenn can you take a look

fixes #1080

tlvenn
tlvenn reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@tlvenn tlvenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this @maartenvanvliet !

test/absinthe/schema/rule/object_must_implement_interfaces_test.exs Show resolved Hide resolved
@tlvenn tlvenn merged commit 6889e0b into absinthe-graphql:master Nov 26, 2021
@maartenvanvliet maartenvanvliet deleted the issues/1080 branch November 26, 2021 08:39
@tlvenn tlvenn mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlvenn tlvenn tlvenn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maartenvanvliet @tlvenn