MG-2296 - Domain creation allowed with nil alias #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
rodneyosodo
requested changes
Jun 18, 2024
JeffMboya
changed the title
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
dborovcanin
changed the title
dborovcanin
changed the title
dborovcanin
requested changes
Jun 18, 2024
auth/postgres/init.go
Outdated
| Up: []string{ | ||
| `ALTER TABLE domains | ||
| ALTER COLUMN alias SET NOT NULL, | ||
| ADD CONSTRAINT alias_not_empty CHECK (alias <> '');`, |
There was a problem hiding this comment.
There is a need for this constraint. It makes sense, but for consistency with the rest of the codebase, let's have this check on API or svc layers.
There was a problem hiding this comment.
Additonal to this constraint, we can add the this check in API Layer, where we do data validation.
There was a problem hiding this comment.
Since you have added API validation, please remove it from the DB for the sake of consistency with the rest of the codebase.
arvindh123
requested changes
Jun 19, 2024
auth/postgres/init.go
Outdated
| Up: []string{ | ||
| `ALTER TABLE domains | ||
| ALTER COLUMN alias SET NOT NULL, | ||
| ADD CONSTRAINT alias_not_empty CHECK (alias <> '');`, |
There was a problem hiding this comment.
Additonal to this constraint, we can add the this check in API Layer, where we do data validation.
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
arvindh123
approved these changes
Jun 20, 2024
dborovcanin
approved these changes
Jun 20, 2024
andychao217
pushed a commit
to andychao217/magistrala
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix
What does this do?
This PR modifies the
aliasfield in theauthtable to be NOT NULL and/or empty and UNIQUE. This prevents the creation of a domain with a NULL or empty alias, which was previously allowed.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Notes