Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

RT 67918 #2

Merged
merged 1 commit into from about 2 years ago

2 participants

Todd Rinaldo Andy Wardley
Todd Rinaldo

2.23 is showing up some errors with command line parsing of Makefile.PL. It was there previously in 2.22 but is showing up more now everyone's upgrading to 2.23. Any chance 2.24 could be around the corner? I'd be happy to facilitate a release if you'd like.

Thanks,
Todd

...l

signs were in an arguement.

Andy Wardley abw merged commit 83fe7ef into from January 24, 2012
Andy Wardley abw closed this January 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 24, 2012
Todd Rinaldo Fixed bug RT#67918 - Bug in Makefile.PL command line parsing when 2 e…
…qual

signs were in an arguement.
28ffe70
This page is out of date. Refresh to see the latest.

Showing 2 changed files with 9 additions and 2 deletions. Show diff stats Hide diff stats

  1. 7  Changes
  2. 4  Makefile.PL
7  Changes
@@ -11,6 +11,13 @@
11 11
 #========================================================================
12 12
 
13 13
 #-----------------------------------------------------------------------
  14
+# Version 2.24 - ??
  15
+#------------------------------------------------------------------------
  16
+
  17
+* Fixed bug RT#67918 - Bug in Makefile.PL command line parsing when 2 =
  18
+  signs were in an arguement.
  19
+
  20
+#-----------------------------------------------------------------------
14 21
 # Version 2.23 - 21st January 2012
15 22
 #------------------------------------------------------------------------
16 23
 
4  Makefile.PL
@@ -42,8 +42,8 @@ $MAKE=$Config{'make'};
42 42
 # goes into $config
43 43
 
44 44
 my (%config, %ttconfig);
45  
-while ($_ = shift) {
46  
-    my ($k, $v) = split(/=/);
  45
+while (shift @ARGV) {
  46
+    my ($k, $v) = split(/=/, $_, 2);
47 47
     if ($k =~ /^TT/) {
48 48
         $ttconfig{ $k } = $v || 0;
49 49
     }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.