Add support for %z. Fix #132 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjatria
force-pushed
the
format-offset
branch
from
75d5f51
to
b83879a
Compare
jjatria
force-pushed
the
format-offset
branch
from
b83879a
to
577ab6c
Compare
atoomic
approved these changes
Jan 15, 2020
|
This looks good to me would like to rebase it before merging it as we have some new integration tests |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving #132 in a way that maintains backwards compatibility (and avoid the issues that blocked #192).
This is implemented not in a separate function, but with a separate
use_offsetparameter that can be set globally for those who like to live on the edge. The parameter can be set by name or as the fifth (!) parameter toformat.I am not entirely convinced on the name of the parameter, so I am open to suggestions for a better name.
This contribution brought to you courtesy of the Pull Request Challenge. :)