New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Redis backend via Readthis gem #6
Conversation
Thanks for the PR! Might not have time to test and merge for a bit but it makes sense to me--concerns from anyone else? @nate00 @alexey-dc ? I think tests are running on Academia.edu's private CircleCI repository (not 100% sure since I no longer work there). Not sure the Travis setup was ever finished. |
Because this is a public gem, I'd recommend using Travis CI that everyone can see building status. I could help setting up CI configuration but need your help to enable Travis CI to start building. |
This seems like a good idea to me. I'll review this more closely in the next week, and investigate the CI situation. @dlackty could you add a mention of Readthis to the README? |
I don't think this PR will work as-is. Dalli's (As an aside, I wish there was some sort of duck typing for method options, so we could check for these options directly rather than requiring Dalli specifically.) In any case, I'm gonna work on making the CI public in the next few days. |
Okay, builds are now publicly visible. (There's a clickable badge in the README.) I think that adding Redis support will require the following steps:
I'm not actually sure whether the second one is possible – it depends what the special features are. @dlackty if you want to take on this work, I'm happy to accept an updated PR. Otherwise I'll close this PR and open an issue. |
@nate00 As far as I investigated, the only and main special feature provided by memcached and dalli is To eliminate it, we can just check using regular So I think a better way is to
How do you think? |
@dlackty that sounds exactly right to me. I suppose separating |
After investigation, I decided to give up this branch because there's not only |
Nowadays Redis becomes go-to cache solution for newly created Rails app. It's faster and provides other useful functionalities beyond cache.
P.S. Which CI service is in use right? I saw both Circle & Travis configuration but couldn't find building messages.