New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake for qpOASES #94

Merged
merged 22 commits into from Jun 14, 2017

Conversation

Projects
None yet
3 participants
@roversch
Contributor

roversch commented Jun 13, 2017

In order to provide Windows support

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jun 13, 2017

Codecov Report

Merging #94 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   85.49%   86.06%   +0.57%     
==========================================
  Files          17       16       -1     
  Lines        3060     2684     -376     
  Branches      723      636      -87     
==========================================
- Hits         2616     2310     -306     
+ Misses        368      310      -58     
+ Partials       76       64      -12

codecov bot commented Jun 13, 2017

Codecov Report

Merging #94 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   85.49%   86.06%   +0.57%     
==========================================
  Files          17       16       -1     
  Lines        3060     2684     -376     
  Branches      723      636      -87     
==========================================
- Hits         2616     2310     -306     
+ Misses        368      310      -58     
+ Partials       76       64      -12
@rienq

This comment has been minimized.

Show comment
Hide comment
@rienq

rienq Jun 14, 2017

Collaborator

Wow, this looks already amazing! Do I understand it correctly that you managed to make a CMake build system for qpoases and you are now in the progress of fixing the one for qpdunes, which depends on qpoases? Based on my limited experience from experimenting with Visual Studio, I agree with Robin that CMake is crucial for providing Windows support!
However, what will we do with hpmpc and/or blasfeo then @giaf @zanellia? (related to #61)

Collaborator

rienq commented Jun 14, 2017

Wow, this looks already amazing! Do I understand it correctly that you managed to make a CMake build system for qpoases and you are now in the progress of fixing the one for qpdunes, which depends on qpoases? Based on my limited experience from experimenting with Visual Studio, I agree with Robin that CMake is crucial for providing Windows support!
However, what will we do with hpmpc and/or blasfeo then @giaf @zanellia? (related to #61)

@zanellia

This comment has been minimized.

Show comment
Hide comment
@zanellia

zanellia Jun 14, 2017

Member
Member

zanellia commented Jun 14, 2017

@roversch roversch merged commit 2e772b5 into acados:master Jun 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment